Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Waystone
Waystone
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Ind.ie Projects
  • WaystoneWaystone
  • Issues
  • #53

Closed
Open
Opened Aug 14, 2015 by Aral Balkan@aralMaintainer
  • Report abuse
  • New issue
Report abuse New issue

Radical Restarts refactor: unify Pulse restart handling

We’re handing Pulse restarts differently in several places and it is causing unpredictable and unstable behaviour.

So, it’s time for a ‘Radical Restarts’ refactor, where we manage restarts only from one place, the PulseProcess class:

  1. Set env var on STNORESTART when starting Pulse

  2. On 'close' event, restart Pulse.

  3. The only way to really, truly, actually kill Pulse is to call the .stop() method on Pulse Process.

Then, everywhere else, where we are calling restart() on the Pulse API, call shutdown() instead.

This should fix:

  • The multiple Pulse processes issue.
  • The Pulse dying and not coming back to life issue.
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
1
Labels
refactor
Assign labels
  • View project labels
Reference: project/waystone#53

Like this? Fund us! Your patronage helps keep us independent and going.