Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
A
app
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Site.js
  • app
  • Issues
  • #226

Closed
Open
Opened Aug 22, 2020 by Aral Balkan@aralOwner
  • Report abuse
  • New issue
Report abuse New issue

Nexe issue #758 appears to be fixed; refactor accordingly

The nexe issue nexe@next regression: pkg → assets in package.json of modules being ignored appears to be fixed. We should confirm and refactor accordingly.

This effects library projects that have external resources that need to be bundled in. If this issue is fixed, we can signal that they should be bundled in in the libraries themselves instead of doing it globally in the Site.js build script as we are currently. This will improve the encapsulation of the libraries without requiring specialised logic to bundle them when used with Nexe.

Relevant code points:

  • https://source.small-tech.org/site.js/app/-/blob/master/bin/build.js#L159
  • https://source.small-tech.org/site.js/lib/auto-encrypt-localhost/-/blob/master/package.json#L61
Assignee
Assign to
More important
Milestone
More important
Assign milestone
Time tracking
None
Due date
None
1
Labels
refactor
Assign labels
  • View project labels
Reference: site.js/app#226

Like this? Fund us! Your patronage helps keep us independent and going.